Héctor Gómez

Results 9 comments of Héctor Gómez

I found this pretty interesting, i'm not an expert on it, but Transaction Service feels a bit overloaded with synchronous work, so moving the webhooks execution responsibilities to another service...

I'm closing this due to inactivity + the changes in the PR affect code that was removed from the project (the service does not use a `flush` endpoint anymore).

Open for discussion [here](https://www.notion.so/gnosis-safe/Config-Service-UI-Banner-feature-discussion-abfe48ccd366444298421313191524ea)

> @hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style Sorry @Uxio0, I...

Yes, I'm under the same impression, it seems since we are consuming the events from the Transaction Service instead of relying on the Events Service did solve this.

The main goal would be to have the same metadata that is available on the transactions mappings (which use `AddressInfoHelper` as you pointed out) when calling the `Contract` endpoint directly...

Closing this as with the pseudo automatic SDK generation @iamacook implemented, no room for inconsistencies between the CGW and its clients would be possible.

I've added some changes to adapt the PR to the modified `pricesProvider` field structure (see https://github.com/safe-global/safe-config-service/pull/1124)