Hennadii Stepanov

depends: Fetch miniupnpc sources from an alternative website

7

The https://miniupnp.tuxfamily.org website is unavailable now.

This change: - Is a pure refactor without altering the assembly code, which might be verified, for example, with the https://godbolt.org/ service. - Fixes warning C4244 when compiling with MSVC...

cmake: Rework flags summary

7

This was requested in https://github.com/hebasto/bitcoin/issues/221. The implementation follows the same approach as in https://github.com/hebasto/bitcoin/pull/93. Here are a few excerpts from the summaries: - Linux: ``` Cross compiling ....................... FALSE Valgrind...

cmake: Add `--no-undefined` linker option

6

This PR adds the `--no-undefined` option to a linker, which supports it. From the GNU ld [docs](https://sourceware.org/binutils/docs/ld.html): > `--no-undefined` > > Report unresolved symbol references from regular object files. This...

Is default `-Wl,--no-undefined` desired?

1

Consider the following diff: ```diff --- a/src/secp256k1.c +++ b/src/secp256k1.c @@ -765,7 +765,9 @@ int secp256k1_ec_pubkey_tweak_mul(const secp256k1_context* ctx, secp256k1_pubkey return ret; } +void undefined_function(void); int secp256k1_context_randomize(secp256k1_context* ctx, const unsigned char *seed32)...

cmake: Clean up testing code

2

1. Delete `CTest` module. The `CTest` module handles `CDash` integration, which we do not use. It is not required for testing functionality. 2. Clean up cases when to invoke `enable_testing()`...

cmake: Set top-level target output locations

3

While testing https://github.com/bitcoin-core/secp256k1/pull/1551, I noticed that when cross-compiling a shared library with examples for Windows, the `ctest` fails to run examples with Wine. Adjusting the `PATH` variable in https://github.com/bitcoin-core/secp256k1/blob/4af241b32099067464e015fa66daac5096206dea/examples/CMakeLists.txt#L16-L18 does...

build: :rocket: Remove Autotools and MSVC build systems

7

The ultimate goal :)

cmake: Drop unused packages from Guix manifest

3

Autotools installation is not required at this moment. ~Drafted because of this~ [feedback](https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1699904124): > Autotools might not be used currently for sqlite (libtool still is), but we can't rule out...

The Qt5 was installed as follows: ``` $ sudo pkg install qt5 ``` As a workaround, the `Qt5_DIR` variable can be provided: ``` $ cmake -B build -DBUILD_GUI=ON -DQt5_DIR=/usr/lib/qt/5.15/lib/amd64/cmake/Qt5 ```