bitcoin icon indicating copy to clipboard operation
bitcoin copied to clipboard

Published 20 hours ago • verified publisher icon hebasto

build: :rocket: Remove Autotools and MSVC build systems

Open hebasto opened this issue 1 year ago • 7 comments
trafficstars

The ultimate goal :)

hebasto avatar Apr 23 '24 17:04 hebasto

Unit tests create an artifact in the source tree:

share/rpcauth/__pycache__/rpcauth.cpython-312.pyc

hebasto avatar May 01 '24 11:05 hebasto

Unit tests create an artifact in the source tree:

share/rpcauth/__pycache__/rpcauth.cpython-312.pyc

Fixed.

hebasto avatar May 03 '24 15:05 hebasto

Rebased. More stuff have been removed from the src/univalue .

hebasto avatar May 17 '24 13:05 hebasto

ACK 045f267577abc0f2788311d34d1c31d4b6493ffb

vasild avatar Jun 20 '24 10:06 vasild

Why restore src/minisketch/.gitignore and why drop commit 3e6cf60806 test: Do not write Python bytecode to source directory?

vasild avatar Aug 16 '24 04:08 vasild

Why restore src/minisketch/.gitignore..?

The src/minisketch is a subtree and shouldn't be modified in this PR.

and why drop commit 3e6cf60 test: Do not write Python bytecode to source directory?

It is still not clear which way is preferred. For more details, please refer to https://github.com/bitcoin/bitcoin/pull/30533.

hebasto avatar Aug 16 '24 09:08 hebasto

Rebased.

hebasto avatar Aug 17 '24 07:08 hebasto

Maybe the two commits can be split up into two pull requests? MSVC removal should be doable now, while autotools may or may not be good to keep a few more days, given my comment on the merged cmake pull.

maflcko avatar Aug 28 '24 11:08 maflcko

Looks like this is now https://github.com/bitcoin/bitcoin/pull/30731 and https://github.com/bitcoin/bitcoin/pull/30664, so reviewers of this change may want to go there.

maflcko avatar Aug 28 '24 12:08 maflcko

Looks like this is now bitcoin#30731 and bitcoin#30664, so reviewers of this change may want to go there.

Closing this PR.

hebasto avatar Aug 28 '24 12:08 hebasto