Hennadii Stepanov

Results 317 comments of Hennadii Stepanov

> * My branch above doesn't add a GUI element in the peer view details for first-phase headers height yet; I'd consider that much lower priority than just having progress...

I have reviewed the GUI-specific code and it looks OK, tested it with `QT_FATAL_WARNINGS=1`. I agree it can be merged. UPDATE: This PR adds two new translatable strings, but that...

Guix build on `x86_64`: ``` 6e2886c80eba9c829047c04586b142d5f8f1c53c31aa82834aff39ae5dbf1762 guix-build-d755ffc3277c/output/dist-archive/bitcoin-d755ffc3277c.tar.gz cdf727c45c3283523726b4ec27f051de5931469874af736eac05d48016d6369b guix-build-d755ffc3277c/output/x86_64-w64-mingw32/SHA256SUMS.part 546866b2f0c8067c168a936246c4cda25745c1b484322201230b885511f2abd7 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-debug.zip 31dbb780dff003089d0e9a3a2598cde89453af4f1b18e392a186a6ec14718b48 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-setup-unsigned.exe 39f1c55a2426390f014282d0a736ceb77e461199fde6ccefcef53ecf10dc4960 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64-unsigned.tar.gz 7e4f7dc3475598d187e77cc31842ad2ce876fb98dc42e999b32bdefbf0b79df1 guix-build-d755ffc3277c/output/x86_64-w64-mingw32/bitcoin-d755ffc3277c-win64.zip ```

@luke-jr > What do we gain from this? As the title said: > Drop boost/algorithm/string/replace.hpp dependency

@jarolrod You were reporting about such an issue [before](https://github.com/bitcoin/bitcoin/pull/21495#pullrequestreview-617479435).

#### Guix builds: ``` $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 4498a4450d0224b3da10d5c919a5c227084e44d91ebfb9ec3046555355a52fe0 guix-build-f0474eb84f97/output/aarch64-linux-gnu/SHA256SUMS.part a789916b0dbaf7f125cf825e4b7fb666a187e4c23a71b5d239d6ae7038e73dae guix-build-f0474eb84f97/output/aarch64-linux-gnu/bitcoin-f0474eb84f97-aarch64-linux-gnu-debug.tar.gz 87471634b55a27eff5d8eda37bee12ed5b061f322be6378544e05089e5d684ec guix-build-f0474eb84f97/output/aarch64-linux-gnu/bitcoin-f0474eb84f97-aarch64-linux-gnu.tar.gz c320a995284f080c158290dfd03cbb48d3ee3794456df8a1ac166ddf09214827 guix-build-f0474eb84f97/output/arm-linux-gnueabihf/SHA256SUMS.part...

@fanquake > It would probably be unexpected to someone using depends, that when they happen to build a certain dependency, on a particular OS, they get additional (unrelated) configure options...

Reworked: - based on #23817 - implemented @fanquake's [idea](https://github.com/bitcoin/bitcoin/pull/23609#issuecomment-984249800)