Hennadii Stepanov

Results 182 issues of Hennadii Stepanov

This PR partially reverts: - https://github.com/bitcoin/bitcoin/pull/28967 - https://github.com/bitcoin/bitcoin/pull/29489 After this PR, we can proceed to actually remove the [unused code](https://github.com/bitcoin/bitcoin/pull/28981#pullrequestreview-1991272752) from `src/util/subprocess.h`.

Wallet
Windows

This PR renames the header `*.hpp` --> `*.h` and adjusts the header guard name, which makes it available for processing by linters. Resolved linter warnings.

Refactoring

On systems where `int8_t` is defined as `char`, the `{S,Uns}erialize(Stream&, signed char)` functions become undefined. This PR resolves the issue by testing `{S,Uns}erialize(Stream&, int8_t)` instead. No behavior change on systems...

Tests

``` $ gdb -q --args ./src/test/test_bitcoin -t ismine_tests Reading symbols from ./src/test/test_bitcoin... (gdb) run Starting program: /export/home/hebasto/git/bitcoin/build/src/test/test_bitcoin -t ismine_tests [Thread debugging using libthread_db enabled] warning: could not convert 'mutex_t' from...

Bug

While testing bitcoin/bitcoin#29484, which seems not related to this bug, I've notice the following failure: ``` $ ./autogen.sh $ ./configure $ gmake -C src test/test_bitcoin ... CXX test/test_bitcoin-streams_tests.o In file...

Bug
Linux/Unix
Build system

This PR goal is to facilitate testing CI scripts migration to the CMake.

This PR adds a new CMake-based build system, which can be reused in downstream projects, including Bitcoin Core. Also an MSVC CI task has been added per [feedback](https://github.com/sipa/minisketch/pull/72#issuecomment-1283049075). Autotools vs...

A build system is Ubuntu 22.04: ``` $ g++ --version g++ (Ubuntu 11.2.0-19ubuntu1) 11.2.0 Copyright (C) 2021 Free Software Foundation, Inc. This is free software; see the source for copying...

> w2 = w2 ⋅ 1 = w2 ⋅ wp–1 = w(p+1) > > Since _p_ is odd (recall _p_ is prime), we know we can divide (_p_+1) by 2...