Hennadii Stepanov
Hennadii Stepanov
When a transaction is abandoned in the GUI, a desktop notification pops up as if it was just created, saying either we just sent it, or we just received it....
Fixes bitcoin-core/gui#604. Fixes bitcoin/bitcoin#25146. `SplashScreen::deleteLater()` [does not guarantee](https://doc.qt.io/qt-5/qobject.html#deleteLater) deletion of the `m_splash` object prior to the wallet context deletion. If the latter happens first, the [segfault](https://github.com/bitcoin-core/gui/issues/604#issuecomment-1133907013) follows.
This PR makes check for `DuplicateAddress` error easier and earlier.
Since bitcoin-core/gui#336, the bitcoin-qt shutdown process has been streamlined, and initiating of another event loop is no longer required. This PR applies the same approach for tests.
When run `bitcoin-qt -conf=/home/hebasto/new-conf`, the "Open Configuration File" button tooltip > "Open the Bitcoin Core configuration file _from the working directory_." is misleading.
TL;DR 1. _Use_ [Qt Translator Comments](https://doc.qt.io/qt-5/i18n-source-translation.html#translator-comments) to annotate [`tr()`](https://doc.qt.io/qt-5/qobject.html#tr) calls 2. Do _not_ use disambiguation strings in [`tr()`](https://doc.qt.io/qt-5/qobject.html#tr) calls, except in item 3 3. If two or more identical strings...
While investigating #32 I found a buggy (?) behavior of `QFileDialog`. From the [Qt docs](https://doc.qt.io/qt-5/qfiledialog.html#details): > By default, a platform-native file dialog will be used if the platform has one....
On master (8f80092d78f758fdb2e79e2a832a0c7a26fa2da1): ``` $ cat ~/.config/Bitcoin/Bitcoin-Qt.conf [General] MainWindowGeometry=@ByteArray(\x1\xd9\xd0\xcb\0\x3\0\0\0\0\ta\0\0\0h\0\0\r\x18\0\0\x2\x86\0\0\ta\0\0\0\x80\0\0\r\x18\0\0\x2\x86\0\0\0\0\0\0\0\0\n\0\0\0\ta\0\0\0\x80\0\0\r\x18\0\0\x2\x86) PeersTabSplitterSizes=@ByteArray(\0\0\0\xff\0\0\0\x1\0\0\0\x2\0\0\x1\x12\xff\xff\xff\xff\0\xff\xff\xff\xff\x1\0\0\0\x1\0) RPCConsoleWindowGeometry=@ByteArray(\x1\xd9\xd0\xcb\0\x3\0\0\0\0\r[\0\0\x1\v\0\0\x10p\0\0\x2\xe7\0\0\r[\0\0\x1#\0\0\x10p\0\0\x2\xe7\0\0\0\0\0\0\0\0\n\0\0\0\r[\0\0\x1#\0\0\x10p\0\0\x2\xe7) RecentRequestsViewHeaderState=@ByteArray(\0\0\0\xff\0\0\0\0\0\0\0\x1\0\0\0\x1\0\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\x3\x90\0\0\0\x4\0\x1\x1\x1\0\0\0\0\0\0\0\0\0\0\0\0\x64\0\0\0\x82\0\0\0\x84\0\0\0\0\0\0\0\x4\0\0\0\x9e\0\0\0\x1\0\0\0\0\0\0\0\xb3\0\0\0\x1\0\0\0\0\0\0\x1\xa2\0\0\0\x1\0\0\0\0\0\0\0\x9d\0\0\0\x1\0\0\0\0\0\0\x3\xe8\0\0\0\0\x64) TransactionViewHeaderState=@ByteArray(\0\0\0\xff\0\0\0\0\0\0\0\x1\0\0\0\x1\0\0\0\x2\x1\0\0\0\0\0\0\0\0\0\0\0\x6\x2\0\0\0\x1\0\0\0\x1\0\0\0\x64\0\0\x3\x96\0\0\0\x6\0\x1\x1\x1\0\0\0\0\0\0\0\0\0\0\0\0\x64\0\0\0\x17\0\0\0\x84\0\0\0\0\0\0\0\x6\0\0\0\x64\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\x64\0\0\0\x1\0\0\0\0\0\0\0\x64\0\0\0\x1\0\0\0\0\0\0\0\xec\0\0\0\x1\0\0\0\0\0\0\x1~\0\0\0\x1\0\0\0\0\0\0\x3\xe8\0\0\0\0\x64) UseEmbeddedMonospacedFont=true addrProxy=127.0.0.1:9050 addrSeparateProxyTor=127.0.0.1:9050 bPrune=false bSpendZeroConfChange=true fCoinControlFeatures=false fFeeSectionMinimized=true fHideTrayIcon=false fListen=true fMinimizeOnClose=false fMinimizeToTray=false fReset=true fRestartRequired=false fUseNatpmp=false fUseProxy=false fUseSeparateProxyTor=false fUseUPnP=false...
This PR adds a [CMake](https://cmake.org/)-based build system. Added build instructions and examples to the [`README.md`](https://github.com/hebasto/secp256k1/blob/220628-cmake/README.md#building-with-cmake) file. Added a few toolchain files for easy cross compiling. Discussions on IRC: - https://gnusha.org/secp256k1/2022-06-23.log...
While testing bitcoin-core/secp256k1#1022 I've [noticed](https://github.com/bitcoin-core/secp256k1/pull/1022#issuecomment-986048847) a linker error when cross compiling with `--host=x86_64-w64-mingw32` in particular circumstances. I cannot recall my building environment then, but currently, on Ubuntu 22.04 with gcc...