Hennadii Stepanov

Results 1312 comments of Hennadii Stepanov

@real-or-random > So Autotools always enable `-g -O2` and so far this was pretty useful for us... So as I understand it, `RelWithDebInfo` does this. Could we just set this...

> Though it won't hurt, we never check for `NDEBUG` it in the code. But we use [`assert`](https://en.cppreference.com/w/c/error/assert).

Updated e9cebaaadfa3ba1a0f233d125fe2eed50f3993cb -> 2ecf0dc437db7c38d4428eca9d17b0168287983a ([pr1113.11](https://github.com/hebasto/secp256k1/commits/pr1113.11) -> [pr1113.12](https://github.com/hebasto/secp256k1/commits/pr1113.12)): - rebased > `CMAKE_BUILD_TYPE` seems to be pretty idiomatic in CMake - introduced two new build types: "RelWithAsserts" and "Coverage"; the latter should...

@sipa > * schnorrsig being built (despite being experimental, and experimental modules not enabled) schnorrsig has not been treated as experimental since #995.

From the recent meeting on [IRC](https://gnusha.org/secp256k1/2022-07-18.log): > \ hebasto: so you think we'd still have a config file for cmake? > \ if build, in general, will support config-less routine,...

https://github.com/bitcoin-core/secp256k1/pull/1113#discussion_r910845410: > You should probably add your name here and everywhere else. (I think that's an annoyance here in the library. It would be good to switch to "libsecp256k1 contributors"...

According to yesterday's IRC meeting, copyright headers have been removed from the new added files.

Updated dc9124b2b23c5cfe4f3524b1e7defb528b62b839 -> 8d019748b599193510a61975371805c2841d7990 ([pr1113.14](https://github.com/hebasto/secp256k1/commits/pr1113.14) -> [pr1113.15](https://github.com/hebasto/secp256k1/commits/pr1113.15)): - rebased - improved building with MSVC - improved hygiene of user-provided `CFLAGS`

Updated 8d019748b599193510a61975371805c2841d7990 -> d77e4c89de78c2b2a523e9e56a931db80104a569 ([pr1113.15](https://github.com/hebasto/secp256k1/commits/pr1113.15) -> [pr1113.16](https://github.com/hebasto/secp256k1/commits/pr1113.16), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.15..pr1113.16)): - added `make test` which is CMake's analogue of Autotools' `make check` - various improvements based on feedback from bitcoin/bitcoin#25797 The PR...

Updated d77e4c89de78c2b2a523e9e56a931db80104a569 -> 3dc4de05299835aa4ff39275507858ebd2ecb8f9 ([pr1113.16](https://github.com/hebasto/secp256k1/commits/pr1113.16) -> [pr1113.17](https://github.com/hebasto/secp256k1/commits/pr1113.17), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.16..pr1113.17)): - fixed accidentally broken compatibility with CMake 3.1 Tested on Debian 8 with non-system CMake installation: ```sh $ cmake --version cmake version...