Hennadii Stepanov

Results 1252 comments of Hennadii Stepanov

I can confirm a bug with the wrong app icon when running in Wayland: ``` [hebasto@localhost bitcoin]$ src/qt/bitcoin-qt -signet -printtoconsole -debug=qt QSocketNotifier: Can only be used with threads started with...

A similar bug in other project: https://bugs.documentfoundation.org/show_bug.cgi?id=125934 Also from https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/: > On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead...

> I believe the segfault is due to accessing those contexts after deletion. I can confirm that segfault is due the `context` object has been deleted before the `context.wallet_load_fns.erase(it);` call:...

Maybe start from catching [`QShortcut::activatedAmbiguously()`](https://doc.qt.io/qt-5/qshortcut.html#activatedAmbiguously) signals? It would help to test this PR, and translated GUI and future changes as well.

While reviewing #603, I've made an opinion that > Other approaches like storing unused prune and proxy settings in QSettings looks nicer, as all those settings are GUI-specific.

> which requires the wallet to be locked Do you mean "unlocking" using `WalletModel::UnlockContext`? > Inside `SendCoinsDialog ::PrepareSendText`, before calling `WalletModel::prepareTransaction`, we are looping over all the entries to load...

Going to leave this PR up for grabs. cc @furszy

> Why is this so much more complicated than https://github.com/bitcoin/bitcoin/issues/25146#issuecomment-1129356954 ? Because this change makes the resulted code simpler.

Updated 66646b6f4d63a6bad09ac6bca8247a2549f002d0 -> ec8d6aacd97b8a7d98de3943c626cf49fe4f1ac8 ([pr605.01](https://github.com/hebasto/gui/commits/pr605.01) -> [pr605.02](https://github.com/hebasto/gui/commits/pr605.02), [diff](https://github.com/hebasto/gui/compare/pr605.01..pr605.02)): - dropped unneeded condition

> With this PR Now there are two different manual deletions for wallet handler in two different places. Correct. But indirectly, via deleting of objects, members of which are wallet...