Hennadii Stepanov

Results 1142 comments of Hennadii Stepanov

@khan201kp > What do you mean by wallet name? A `Wallet::getWalletName()` return value: https://github.com/bitcoin-core/gui/blob/77a2f5d30c5ecb764b8a7c098492e1f5cdec90f0/src/interfaces/wallet.h#L82-L83

Updated be3bb3072cf52202b3f334e340bf4992e19b8b5c -> 697107c06e0837014ae24124dd6db81d6cb87485 ([pr1113.01](https://github.com/hebasto/secp256k1/commits/pr1113.01) -> [pr1113.02](https://github.com/hebasto/secp256k1/commits/pr1113.02), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.01..pr1113.02)): - addressed @fanquake's [comment](https://github.com/bitcoin-core/secp256k1/pull/1113#pullrequestreview-1021652809): > Tested using the suggested instructions, on a macos box, but the build fails to link

Updated 697107c06e0837014ae24124dd6db81d6cb87485 -> dba933ac9ffaea9fedf62a9f324891f440c2ca76 ([pr1113.02](https://github.com/hebasto/secp256k1/commits/pr1113.02) -> [pr1113.03](https://github.com/hebasto/secp256k1/commits/pr1113.03), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.02..pr1113.03)): - `make install` works as expected now :tiger2:

Updated dba933ac9ffaea9fedf62a9f324891f440c2ca76 -> ec372dc0b8a95053a771614931982e29291b6dd8 ([pr1113.03](https://github.com/hebasto/secp256k1/commits/pr1113.03) -> [pr1113.04](https://github.com/hebasto/secp256k1/commits/pr1113.04), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.03..pr1113.04)): - added an example of cross compiling for Android - added an example of native compiling on Windows with Visual Studio

Updated ec372dc0b8a95053a771614931982e29291b6dd8 -> d98be43d08fcfaef756309bb3048a57274b0ccb6 ([pr1113.04](https://github.com/hebasto/secp256k1/commits/pr1113.04) -> [pr1113.05](https://github.com/hebasto/secp256k1/commits/pr1113.05), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.04..pr1113.05)): - addressed @real-or-random's comments

Updated ff836b6199d81e63f61afee1b8385e815ca25c47 -> f587a8cfe16704d29ad0d4409a90807ef8320147 ([pr1113.06](https://github.com/hebasto/secp256k1/commits/pr1113.06) -> [pr1113.07](https://github.com/hebasto/secp256k1/commits/pr1113.07), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.06..pr1113.07)): - addressed @fanquake's and @real-or-random's comments - moved toolchain fails into `cmake` directory

Updated f587a8cfe16704d29ad0d4409a90807ef8320147 -> 5dda6460657778e52b89a7920a8b63a032f5183f ([pr1113.07](https://github.com/hebasto/secp256k1/commits/pr1113.07) -> [pr1113.08](https://github.com/hebasto/secp256k1/commits/pr1113.08)): - rebased on top of the #1116 - addressed @real-or-random's [comment](https://github.com/bitcoin-core/secp256k1/pull/1113#discussion_r911167739)

Updated 6b65314195baeee982c7d5213377d493d073f119 -> 13c63e79b56ab00bffb0ff40d8a6a0f4b03ed620 ([pr1113.09](https://github.com/hebasto/secp256k1/commits/pr1113.09) -> [pr1113.10](https://github.com/hebasto/secp256k1/commits/pr1113.10)): - rebased - added `examples/CMakeLists.txt` - option docstrings style now follows CMake's docstring style - addressed @real-or-random's and @sipa's comments - fixed module...

> EDIT: seems `-DCMAKE_BUILD_TYPE=Release` is needed to get optimizations enabled. By default (at least on Linux), `-DCMAKE_BUILD_TYPE=Release` adds `-O3 -DNDEBUG` flags, and `-DCMAKE_BUILD_TYPE=Debug` does `-g`. Therefore, I'd suggest to do...

Updated 13c63e79b56ab00bffb0ff40d8a6a0f4b03ed620 -> e9cebaaadfa3ba1a0f233d125fe2eed50f3993cb ([pr1113.10](https://github.com/hebasto/secp256k1/commits/pr1113.10) -> [pr1113.11](https://github.com/hebasto/secp256k1/commits/pr1113.11), [diff](https://github.com/hebasto/secp256k1/compare/pr1113.10..pr1113.11)): - [improved](https://github.com/bitcoin-core/secp256k1/pull/1113#discussion_r912388756) documentation - removed the [`ENABLE_DEV_MODE`](https://github.com/bitcoin-core/secp256k1/pull/1113#discussion_r916979117) option