Harrison Carter
Harrison Carter
Can this ticket be closed, since we now have a fingerprint for this device?
Can we close this pull request?
Completed testing using the following VDA devices on my personal v3: 1. Virtual OnOff Switch 2. Virtual Dimmer Switch 3. Virtual Color Dimmer Switch 4. Virtual Bridge with multiple instances...
We don't currently support the fan speed capability for thermostat, and that is on purpose. We have internally discussed adding this, but for now we do not plan to add...
I believe similar functionality could be achieved by simply reordering the if-else logic in `do_configure`. Specifically, if we put the `elseif device_type == FAN_DEVICE_TYPE_ID then` at the bottom of the...
we need a fingerprint for the device :+1:
Just a reminder @DongHoon-Ryu, please squash your commits before merging into main. Thank you very much.
Closing in favor of [1916](https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1916)
@HunsupJung I think it would be good to add a unit test to make sure the distinction in oven between C and F is working correctly?
@nickolas-deboom in your latest commit, you removed the setting of the CURRENT_CONFIGURED_UNIT field. Was this purposeful?