SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

CHAD-13781: Re-profile devices with a bad wind feature map

Open hcarter-775 opened this issue 1 year ago • 3 comments

Check all that apply

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [X] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [X] I have performed a self-review of my code
  • [X] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [X] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-13761 Re-profile devices with a bad wind feature map See description in this Jira ticket for more information.

Summary of Completed Tests

Unit test written to catch this case

hcarter-775 avatar Aug 13 '24 23:08 hcarter-775

Test Results

   62 files    383 suites   0s :stopwatch: 1 863 tests 1 863 :white_check_mark: 0 :zzz: 0 :x: 3 250 runs  3 250 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 0ed25d59.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 13 '24 23:08 github-actions[bot]

File Coverage
All files 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 0ed25d59fc299c5d2f47957b92682b03f9dcdeeb

github-actions[bot] avatar Aug 13 '24 23:08 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Aug 15 '24 03:08 github-actions[bot]

Closing in favor of 1916

hcarter-775 avatar Feb 07 '25 18:02 hcarter-775