material-ui
material-ui copied to clipboard
mui
[base] Move hooks to their own directories
- [x] I have followed (at least) the PR section of the contributing guide.
This PR fixes #33903
As explained in issue #33903, the hooks from unstyled components needed to be moved to their top-level directories.
| Messages | |
|---|---|
| :book: | Netlify deploy preview: https://deploy-preview-34401--material-ui.netlify.app/ |
Bundle size will be reported once CircleCI build #442633 finishes.
Generated by :no_entry_sign: dangerJS against 759694ebfb977f1cc64a23c22d4cc82f8f3fbd5e
Hi! I try to do everything asked at the issue. If you need something different, just let me know.
I just have a problem if the imports/exports of files, and I could only solve modifying the .eslintrc.js file with 'import/no-named-as-default': 'off'. If that's not a good practice, or if you have another idea, please, let me know!
Thanks @kabernardes let's wait for @michaldudak to come back from his vacation before going forward with this. You should get review by the end of the week :)
Hi @kabernardes! Do you need any help with this? Recently some changes landed on master that caused conflicts with your code. Let me know if any of them are problematic to resolve.
@michaldudak if we want to move forward with this, I suggest someone from the core team take care of it. Do all the changes necessary and merge the PR right away. Waiting for a review, and going back and forward will require re-base nonstop, which is just delaying the work :)
I am working on this task in a separate PR due to lots of merge conflicts. https://github.com/mui/material-ui/pull/36235. Hence, I am closing this PR.
