Alvin Zou
Alvin Zou
@bennybroseph @Madmadness65 Could I get a review on this? Thanks!
Seems like this effort has already been started: https://github.com/pagefaultgames/pokerogue/pull/485
> What happens when you cancel on the Ability screen? Closes the summary screen, as expected: https://github.com/pagefaultgames/pokerogue/assets/59787978/52e91e35-a435-4cee-b910-62fe8c8c7354
> Ain't no way you made me boot up Scarlet just to find out it was false 😢 > > 0513.1.mp4 oh shit mb I thought I had seen this...
> The other PR is missing German while this one is missing Chinese The other PR doesn't have German because the updated German description was already merged into main: https://github.com/pagefaultgames/pokerogue/commit/7b7df5b245f8b3ac2bfef0b2c7f20210a772f165
Looks like @jaimefd already made a PR implementing this move: https://github.com/pagefaultgames/pokerogue/pull/695 I think this PR has a much cleaner way of implementing this, however.
Hmm if we're doing this, maybe we allow passing a string argument into `partial()` that explains what has not been implemented yet, and then we can include that info in...
> I doubt this is going to work, so I'll just ask about some of the cases where I expect it not to work. > > Has this been tested...
@Xavion3 Could you give this another look? Thanks!
> After poking through the files, issue seems to be that the data about the arena saved to session in game_data.ts only saves weather but not terrain, which seems obvious,...