pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Add Documentation to All Partial (P) Moves and Abilities

Open f-raZ0R opened this issue 9 months ago • 2 comments

This pull request adds comments to every partially implemented move or ability that does not already have one, explaining what about the move or ability still needs to be worked on.

Additionally, this adds the partial tag to Prankster and Pastel Veil, as both of these abilities do still need an aspect of them implemented (prankster not working on dark types, and pastel veil also affecting allies in a double battle).

f-raZ0R avatar May 09 '24 23:05 f-raZ0R

Hmm if we're doing this, maybe we allow passing a string argument into partial() that explains what has not been implemented yet, and then we can include that info in the description of the move. Since we're already telling users if a move is partially implemented, I think it would be fine to also augment the move description with what still needs to be implemented. Maybe this would be exposing too much information to the user, would love to get some thoughts on this.

happinyz avatar May 10 '24 00:05 happinyz

This is actually great if reviewed to be accurate

hassanoza22 avatar May 10 '24 04:05 hassanoza22

After discussion with @f-raZ0R, better to assist with updating this document instead. Closing this out.

bennybroseph avatar May 12 '24 05:05 bennybroseph