Joshua Haberman

Results 252 comments of Joshua Haberman

What is the purpose of this change? What is the goal of adding a `.gitattributes` file?

> The goal of this pull request is to allow projects to track the composer downloaded copy of this package in a git repository and for PHP to be able...

The PR should not be merged directly. It will be applied as a CL internally and then propagated back to GitHub. This workflow is triggered automatically when an approved PR...

@dazuma could you take a look? This relates to the binary package. It may be that this `wrap_memcpy()` issue is obsolete, and the wrapper can simply be removed. There was...

What is the use case for this? Is it for easy copy paste when you have one line per option? eg. ```proto syntax = "proto3"; package test; import "google/protobuf/descriptor.proto"; extend...

How are you building protobuf? The `decode_fast.c` file is not enabled in any of our normal builds (Bazel, CMake, etc). Are you using a custom build setup?

> decode_fast/encode_fast will be removed ? or temporarily unavailable? decode_fast is currently unmaintained. If and when there is a use case that needs the extra parsing speed (and can tolerate...

Hi @jufemaiz, can you clarify exactly what the proposed resolution is here? Would that change break any existing use cases?

Please note that the `ffi/` directory is an experimental implementation that is not currently the default. The default implementation is written in C: https://github.com/protocolbuffers/protobuf/blob/8d8db9cea8eb442a57286f33ec1e802c5d6c3149/ruby/ext/google/protobuf_c/message.c#L831-L840 I don't quite understand how options...