Joshua Haberman
Joshua Haberman
Which compiler is raising these warnings? What compiler version and what compilation flags?
I don't think this is the correct fix. The real issue here is that both `upb_WireReader_ReadTag()` and `upb_WireReader_ReadSize()` can return `NULL` to indicate error, and in that case the variables...
It's possible that we may need to add `UPB_ASSUME(ret != NULL)` into the success paths of the WireReader functions also.
The `upb` library which underlies Ruby Protobuf currently supports serializing to, but not parsing from, TextFormat: https://github.com/protocolbuffers/protobuf/tree/main/upb/text So adding a text format encoder would be pretty straightforward. But adding a...
I'm not sure exactly what test files would be helpful (I'm not deeply familiar with crel so couldn't suggest how to get good coverage). But a recent Clang should be...
I have a PR out for building s390x binary wheels: https://github.com/protocolbuffers/protobuf/pull/23527
I'm not sure that our code is Ractor-safe at the moment. We use a global object cache to map C pointers to Ruby objects: https://github.com/protocolbuffers/protobuf/blob/15e7d71eacd7df66531aae2bb7c9b8b8a1a81483/ruby/ext/google/protobuf_c/protobuf.c#L236 We would need to remove...
Are ffi-based libraries necessarily Ractor-safe? What if they are accessing shared state? Our ffi implementation also uses a global object cache: https://github.com/protocolbuffers/protobuf/blob/main/ruby/lib/google/protobuf/ffi/object_cache.rb#L28 I think it would take some careful work...
Could you please reduce this down to the smallest program that will reproduce the issue? Also, does it reproduce on any other platforms, or just PPC? We don't have access...
Does it work if you add: ```ruby require 'google/protobuf/descriptor_pb' ```