protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Closes #11203 Update packagist mirror repo to include a .gitattributes file.

Open trackleft opened this issue 10 months ago • 5 comments

This pull request adds a .gitattributes file into the https://github.com/protocolbuffers/protobuf-php repo during the Update PHP Repo workflow update process.

Alternatively we could add this .gitattributes into the https://github.com/protocolbuffers/protobuf/tree/main/php folder and update the action to include it when building the packagist repo.

trackleft avatar Apr 18 '24 21:04 trackleft

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 18 '24 21:04 google-cla[bot]

~~How do I rerun the check CLA action?~~

trackleft avatar Apr 18 '24 21:04 trackleft

What is the purpose of this change? What is the goal of adding a .gitattributes file?

haberman avatar Apr 26 '24 20:04 haberman

The goal of this pull request is to allow projects to track the composer downloaded copy of this package in a git repository and for PHP to be able to use the artifact copy of the package.

At the moment git stores and tracks these files as a type of file that PHP can not use.

The .gitattributes file just tells git to store php files as text files so PHP can use them.

trackleft avatar May 07 '24 19:05 trackleft

The goal of this pull request is to allow projects to track the composer downloaded copy of this package in a git repository and for PHP to be able to use the artifact copy of the package.

This isn't really a use case we support or test for. We support usage from a normal composer install.

If you are copying the composer install into a Git repo, can you create the .gitattributes file at that point?

haberman avatar May 10 '24 17:05 haberman

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

github-actions[bot] avatar Aug 09 '24 10:08 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar Aug 23 '24 10:08 github-actions[bot]