Guewen Baconnier

Results 131 comments of Guewen Baconnier

Another good point of using odoo upgrades is if we have to deploy a project on odoo.sh, we'd use the same method. On the downsides, sometimes we couldn't even start...

> I'd like to ask you most to check, if you agree with the Author and contributor assignments so everything is in order and all rights are duly respected to...

Hi @etobella , thanks! About ``` connector/doc/conf.py:18: [W7936(missing-manifest-dependency), ] Missing external dependency "sphinx_bootstrap_theme" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies ``` Do you know if we have a way to exclude `sphinx_bootstrap_theme`...

Looks like https://github.com/OCA/odoo-pre-commit-hooks/blob/main/src/oca_pre_commit_hooks/checks_odoo_module_po.py is a bit too broad. An easy fix would be to add `connector/doc/locale` in .pre-commit-config.yaml 's exclude, but I'm not sure it'd resist the next dotfile update?

I missed the biggest point which is a problem for this implementation: channels configuration is loaded before loading databases, and it may be different from database to database.

Hey, it was definitely something that bothered me at some point and wanted to improve. I remember fiddling with it at some point but did not reach a working/mature solution.

Hi @sonhd91 thanks for the fix! You fixed the import correctly, however we should handle `sphinx_bootstrap_theme` differently IMO, I suggest to remove it from this PR and handle it in...

Hi @ivantodorovich , creating a new job that inserts itself in a new dependency of the current job and then retry the later which such becomes in a wait_dependencies state...

Admittedly if the job is already in a graph it may not do what we want neither