Guewen Baconnier
Guewen Baconnier
> As I'm sure you are aware You make me more knowledgeable that I am :-) I don't know how to develop Magento extensions. Should be nasty when 2 addons...
Good idea, it would be nice indeed.
Yes `install_in_connector()` is no longer required (yeah!) and we can remove it. Not a high priority issue but an easy pick. (should be removed from the doc as well)
On the backend, there is an option that indicates if tax is included in price or not and I think it changes this behavior. Could you check that?
Pity. Getting all the options working together in all possible ways is really tricky with incl. and excl. taxes. I have no clue for that yet.
Here is the mapping for the discount: https://github.com/OCA/connector-magento/blob/8.0/magentoerpconnect/sale.py#L961-L972 And a test which proves to be insufficient here: https://github.com/OCA/connector-magento/blob/8.0/magentoerpconnect/tests/test_synchronization.py#L240-L266 There is no general documentation for that.
(`record` in the method contains the values from Magento)
@aignermi does it depend on a configuration on Magento perhaps? I know Magento had a handful of options such as compute discount after total, before taxes, ...
I mean we can remove this logic in the discount, but I don't want to break other scenario, if it was there at a first place, I think (I hope)...
> if I set the parameter to yes, I would have the double tax value in Odoo Why not set tax include taxes on the products?