connector icon indicating copy to clipboard operation
connector copied to clipboard

[15.0] dotfiles update needs manual intervention

Open etobella opened this issue 2 years ago • 4 comments

Dear maintainer,

After updating the dotfiles, pre-commit run -a fails in a manner that cannot be resolved automatically.

Can you please have a look, fix and merge?

Thanks,

etobella avatar Oct 27 '23 20:10 etobella

Hi @etobella , thanks!

About

connector/doc/conf.py:18: [W7936(missing-manifest-dependency), ] Missing external dependency "sphinx_bootstrap_theme" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies

Do you know if we have a way to exclude sphinx_bootstrap_theme from the requirements? As it's needed only to build the documentation, not by the addon itself.

guewen avatar Oct 30 '23 13:10 guewen

@guewen the fix is created, but the problem comes from the translation of documentation. I don't know why it is analized :sob:

etobella avatar Oct 31 '23 09:10 etobella

Looks like https://github.com/OCA/odoo-pre-commit-hooks/blob/main/src/oca_pre_commit_hooks/checks_odoo_module_po.py is a bit too broad. An easy fix would be to add connector/doc/locale in .pre-commit-config.yaml 's exclude, but I'm not sure it'd resist the next dotfile update?

guewen avatar Oct 31 '23 14:10 guewen

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 03 '24 12:03 github-actions[bot]