Andrea Franz
Andrea Franz
@lateefj if you can rebase I can check again and then merge your PR
Yes, I think the best way is to change all the custom exception and make them inherit from StandardError. what do you think?
you told me that in the title, I replied just after reading the body :) feel free to send me a pull request!
Hi guys, thank you for your work. I'm in the middle of a complete rewrite of fresh, and I would like to wait for that before merging this. can you...
@CaledoniaProject you are right, but everything is used in the string format for now. feel free to open a PR if you want to fix it :)
@DanieleSalatti are we still blocked here? if not can you merge it when it's ok for you please? /cc @michellema1208
/cc @michellema1208
@michellema1208 yes I think it should be the same for all the forms we have
here are some comments, I think no major issues have been found so far.
All these functions should be set as external: - ProgramFactory.initialize() (contracts/program/ProgramFactory.sol#24-27) - ProgramFactory.updateProgramContract(address) (contracts/program/ProgramFactory.sol#37-41) - ProgramImplementation.initialize(bytes) (contracts/program/ProgramImplementation.sol#46-75) - ProgramImplementation.updateMetaPtr(MetaPtr) (contracts/program/ProgramImplementation.sol#79-82) - RoundFactory.initialize() (contracts/round/RoundFactory.sol#37-40) - RoundFactory.updateRoundContract(address) (contracts/round/RoundFactory.sol#50-54) - RoundImplementation.initialize(bytes) (contracts/round/RoundImplementation.sol#104-167) -...