Andrea Franz
Andrea Franz
slither has some warning on dangerous comparisons with timestamps, which can be manipulated by miners. but in our case I don't think it's a problem because all these functions are...
Naming convention slither has many warnings on function arguments starting with `_` but I think it's used in many contracts in the same way so it shouldn't be a problem.
Lack of zero check. I don't think it's a problem since they are all functions callable by admins. - ProgramFactory.updateProgramContract(address)._programContract (contracts/program/ProgramFactory.sol#37) lacks a zero-check on : - programContract = _programContract...
Empty lines. * blank line at contracts/program/ProgramFactory.sol#22 can be removed
good catch @jpascal thank you! yes that need to be changed.