grant-hub icon indicating copy to clipboard operation
grant-hub copied to clipboard

create/edit project & application: fix labels when questions have long text

Open gravityblast opened this issue 3 years ago • 6 comments

User Story As a project owner, I want to know which questions are required vs. optional, so that I know what questions I need to answer in order to move to the next step

Acceptance criteria:

  • [ ] Limit the width of the input title so we can always keep the required/optional tag right-aligned on Round Application form
  • [ ] Limit the width of the input title so we can always keep the required/optional tag right-aligned on Create Project form
  • [ ] Limit the width of the input title so we can always keep the required/optional tag right-aligned on Edit Project form

Image

gravityblast avatar Sep 13 '22 23:09 gravityblast

/cc @michellema1208

gravityblast avatar Sep 13 '22 23:09 gravityblast

@michellema1208 we could put the * required below the input maybe?

codenamejason avatar Sep 13 '22 23:09 codenamejason

We can limit the width of the input title so we can always keep the required/optional tag on the right! image

willsputra avatar Sep 20 '22 18:09 willsputra

⚠️ Status Update: Moving back to "In Progress"

@DanieleSalatti I just tested this change on staging, and although it looks like the label and questions are no longer overlapping, it still looks pretty tight to me, and missing the 8px gap between question and label that Will shared in the screenshot above (reposting below). I believe once the question hits the threshold (to maintain a 8px gap between question and label), the remainder of the question needs to be on a newline.

Tagging in @willsputra to review and confirm as well!

Will's design update: Image

What the application page looks like on staging: Image

michellema1208 avatar Sep 23 '22 20:09 michellema1208

Nice catch, that first label behaves differently for some reason. I'll fix it.

Image

DanieleSalatti avatar Sep 24 '22 22:09 DanieleSalatti

✅ Status Update: Moving to "Ready for Deployment"

@DanieleSalatti just tested, & accepting changes for this ticket!

michellema1208 avatar Sep 28 '22 00:09 michellema1208