Marco Granelli
Marco Granelli
We only implemented the extra unrelated step. We were speaking the other day about the fact that, at the moment, if a transaction doesn't carry an expiration, is valid indefinitely....
I believe we can just use the `expiration` field of the transaction. This is currently an `Option` (and I believe it should remain so because protocol transaction don't expire). We...
There's a failing unit test and I left a minor comment. Overall it looks good to me but I'd like a second opinion from @brentstone especially for the query and...
Yes, my bad, I forgot to add this to the queue of the last draft branch. I'll rebase it and mark it as ready for draft
@yito88 do you think this error could be due to Hermes?
> Just a few quick clarifications on your summary: > > > Precommit or drop the changes of an inner tx before launching the next one to ensure that every...
@yito88 this pr changes the structure of the `Tx` once more so we'll probably need another update of Hermes
Yes it is
To me it looks like, as long as we don't shift the variants of the `ResultCode` enum but we just add new ones, this should be a non-breaking change
Also, we should consider adding one more `ResultCode` variant for failed atomic batches that performed masp fee payment: in this cases we still commit the first transaction of the batch...