Marco Granelli

I'm not sure this is really needed nor necessarily nice to have. For the commitment tree we need to keep older versions of the tree's root in storage because this...

Actually, one small thing, I believe we need to review and update the shielded rewards estimate function: https://github.com/anoma/namada/blob/102adbbef0881d79ca3c82acfee15ec71d057dfe/crates/shielded_token/src/masp/shielded_wallet.rs#L692 We were handling the rewards with `Epoch(0)` and also accounting for the...

> > Actually, one small thing, I believe we need to review and update the shielded rewards estimate function: > > https://github.com/anoma/namada/blob/102adbbef0881d79ca3c82acfee15ec71d057dfe/crates/shielded_token/src/masp/shielded_wallet.rs#L692 > > > > We were handling the...

> I have left a few suggestions, nothing too annoying to fix, I hope. Overall, this is a fine solution. The only thing I would point out is that it...

A small comment, we can probably remove this FIXME that I had left back when we introduced batched transactions https://github.com/anoma/namada/blob/9527ea975372b7a4654ca31ac85ca2091dac55f9/crates/sdk/src/signing.rs#L1069

Actually it seems like we call `add_block_to_batch` only once and we provide a `true` value for `is_full_commit`, so I'm not even sure we need that argument at all

@dan-u410 do you think this PR is still relevant?

Especially atomic batches

@sug0 just noticed that the last hex char of the inner tx hash differs between when he submits the tx and when he gets the result of the query back

In addition, we should also review the `signatures` and `wrapper_signature` fields of `args::Tx`. We should be using these only when loading a tx from storage (with the `tx` command), so...