Marco Granelli
Marco Granelli
An update on this issue being breaking: it's technically non breaking since in protocol we'd just swap a `BTreeSet` out for an `IndexSet`. It's not breaking on the client side...
I'm closing this issue. Since the `BTreeSet` of events is split and indexed inside a `PatriciaMap`, changing it to an `IndexSet` would only partially fix the ordering. Also, #4454 will...
Right now it is not possible to apply the changes suggested here because the hardware wallet can only handle wrapped transactions. We could come back at this if we ever...
@yito88 Hermes tests failing again (sorry about that)
> @yito88 Hermes tests failing again (sorry about that) Ah actually I believe the failures come from #3391
> yeah, it seems that the parameter structure change in #3391 causes the failure. Maybe not, I've just pushed a fix to that branch that was supposed to fix a...
> do we still want this PR? I think it would be nice if we could add it to the next release
> @grarco Looks good. `e2e::ibc_tests::run_ledger_ibc` failed without Hermes. It seems that the default gas limit isn't enough for `tx_ibc.wasm`. Thanks for catching it! Should be fixed in fb81246a0e9179384bec1838f8a2229d17d09e64. I've also...
Let's wait for the CI to come back online before reviewing this cause there's a change we might have a few tests failing due to gas
> Let's wait for the CI to come back online before reviewing this cause there's a change we might have a few tests failing due to gas Ok I've fixed...