Gary O'Neall

icon indicating a website link sourceauditor.com icon indicating an email [email protected]

icon company Source Auditor Inc. icon location San Francisco Bay Area icon location Contributor to Linux Foundation @spdx and @OpenChain-Project projects. Consultant providing technical due diligence and open source compliance services.

Results 1059 comments of Gary O'Neall

License submission form-XML editor: exception v license

@jlovejoy Agree it would require some changes to the UI.

Create a builder pattern for the objects that have longer parameter lists

See [SpdxFile](https://github.com/spdx/Spdx-Java-Library/blob/master/src/main/java/org/spdx/library/model/SpdxFile.java) for an example of the builder pattern. This pattern was introduced late in the development of the library. It would be nice to add this to some of...

Create a builder pattern for the objects that have longer parameter lists

Hi @amCap1712 Thanks for taking this on. One suggestion - In the other classes that use builders, I used a slightly different pattern where the builder is passed in as...

Include hasFiles and documentDescribes information in relationship comparison

Thanks @meretp for the detailed explanation of the issues. > In general I would expect that the comparison is somehow independant from the direction of the relationship although I see...

Include hasFiles and documentDescribes information in relationship comparison

In looking at the effort involved, I don't think it would make sense to fix this before 3.0. The 3.0 spec has some structural changes in the relationships that will...

Include hasFiles and documentDescribes information in relationship comparison

Clarification on the "won't fix" label - won't be fixed before SPDX spec version 3.0. Once the SPDX spec version 3.0 is released, we'll reconsider working on this issue.

Add unit tests that exercise issue #234

Thanks @pmonks - closing the issue

Templates with <<var... tags in a string without spaces does not match correctly

This turns out to be a very challenging fix - we need access to the alt tag spacing hints which are not preserved in the template. There are two approaches...

Verify error when license exceptions are used in an expression in LicenseConcluded but not in LicenseInfoInFile

Since `LicenseInfoInFile: Qt-GPL-exception-1.0` is an exception and not a license, it should only be used on the right side of a `WITH` expression. If `LicenseInfoInFile: LicenseRef-Qt-Commercial` passes validation, then there...

Verify error when license exceptions are used in an expression in LicenseConcluded but not in LicenseInfoInFile

Transferring this to the library repo where the parsing code is implemented.