Gary O'Neall

icon indicating a website link sourceauditor.com icon indicating an email [email protected]

icon company Source Auditor Inc. icon location San Francisco Bay Area icon location Contributor to Linux Foundation @spdx and @OpenChain-Project projects. Consultant providing technical due diligence and open source compliance services.

Results 1059 comments of Gary O'Neall

Donate the SPDX header checker to this org?

I'll send an update to SPDX tech list and if there are no general objections by next week, we can go ahead and move it to SPDX.

Store license diff screenshot in database instead of uploading to github

@jlovejoy - not resolved yet - a good idea, but probably lower priority to other issues.

Improve testing to check for edge cases

@jlovejoy It's a pretty general issue and still applicable to other workflow items. I'm 50/50 on keeping it open. @rtgdk what do you think?

Method `LicenseInfoFactory::getListedLicenseById` never returns `null`

Thanks @dwalluck for pointing this out. I looked at the code, and it looks like it will create the license if it doesn't exist based on [this method](https://github.com/spdx/Spdx-Java-Library/blob/d837b8c943f2f7e5cfec0445d0e0d962f91b1f0d/src/main/java/org/spdx/library/model/license/ListedLicenses.java#L177) which defaults...

Error handling for postScreenShot does not render correctly

> Can you assist me on recreating the error? Since the original error where I found this has now been fixed, you'll probably have to "fake" an error in the...

Error handling for postScreenShot does not render correctly

@ronisarkarexe - It is still an issue, just difficult to reproduce since we need to "fake" an error.

Fixing the issue of striping attributes when beautify

@BanulaKumarage @rtgdk - Should this be merged?

Unit test failure - test_post_submit

> FYI, All the test cases that are failing are the once that were skipped because they require github credentials which is why these tests were not tested. I will...

Unit test failure - test_post_submit

@BanulaKumarage Probably a better question for @rtgdk - I'm not as familiar with the unit test code

Create a mechanism to limit the requests to the online tools

@pombredanne Not a current problem, but it has not been widely advertised (still waiting for the Linux Foundation to provide the server). Good point on the Django features - this...