spdx-online-tools icon indicating copy to clipboard operation
spdx-online-tools copied to clipboard

License submission form-XML editor: exception v license

Open jlovejoy opened this issue 2 years ago • 9 comments

XML creator automatically uses "license" even if it's an exception. Not sure there's a way to change this as we'd probably need a way to designate it as an exception in the submission form?

jlovejoy avatar Oct 15 '22 15:10 jlovejoy

@jlovejoy Agree it would require some changes to the UI.

goneall avatar Oct 15 '22 17:10 goneall

Some more notes on this:

  • add tick box as to license or exception in submission form
  • this then dictates the appropriate tag when creating the XML and the PR (to put the XML in the exceptions folder)

Also note: currently, if you change License --> exception in that tag, and then "beautify" it strips out the other attributions for the license/exception tag.

jlovejoy avatar Feb 12 '23 22:02 jlovejoy

Hi @jlovejoy,

Also note: currently, if you change License --> exception in that tag, and then "beautify" it strips out the other attributions for the license/exception tag.

Can you kindly explain what is meant by this line?

HirumalPriyashan avatar Mar 26 '23 02:03 HirumalPriyashan

it's hard to explain in text, if you test the XML editor via one of the submissions it will make more sense. Basically, if you try to change the license tag to exception. then use the "beautify" function in the xml editor, it "corrects" the tag back to

jlovejoy avatar Mar 27 '23 03:03 jlovejoy

I see, thanks for the clarification. I noticed beautify strips out the content of the exception tag in that case.

HirumalPriyashan avatar Mar 27 '23 13:03 HirumalPriyashan

@goneall @rtgdk - looks like there are two PRs open against this issue - should we close one?

jlovejoy avatar Jun 21 '23 19:06 jlovejoy

@BassCoder2808 - could you comment here (so I can assign you to this issue) :)

jlovejoy avatar Jun 21 '23 19:06 jlovejoy

Sure @jlovejoy

BassCoder2808 avatar Jun 21 '23 21:06 BassCoder2808

ah, the related PRs to this issue have not been merged, so won't see fix yet!

jlovejoy avatar Jul 13 '23 21:07 jlovejoy