Spdx-Java-Library icon indicating copy to clipboard operation
Spdx-Java-Library copied to clipboard
verified publisher icon spdx

Add unit tests that exercise issue #234

Open pmonks opened this issue 1 year ago • 2 comments

This PR adds unit tests that exercise issue #234. They're (deliberately) minimal, since license comparison is expensive and already a sizable portion of the runtime of the unit tests, but they at least show what's going on with that issue as of v1.11 of the library.

Note: the tests are failing because this PR only adds (previously missing) unit tests to demonstrate issue #234, but not logic to fix it.

pmonks avatar Apr 23 '24 22:04 pmonks

Thanks @pmonks - creating unit tests will help in diagnosing/fixing the issues.

It may be a while before I can look at these issues - I'm prioritizing getting the SPDX 3.0 supported.

goneall avatar Apr 23 '24 23:04 goneall

@goneall yep absolutely no problem - I know just how busy you've been with the 3.0 release and updating the library to match!

pmonks avatar Apr 23 '24 23:04 pmonks

@goneall I believe this PR can be closed without merging, as the changes here were merged as part of PR #249.

pmonks avatar Sep 24 '24 16:09 pmonks

Thanks @pmonks - closing the issue

goneall avatar Sep 24 '24 22:09 goneall