Gleb Mazovetskiy

icon company Google icon location London icon location Open-source all the things.

Results 440 comments of Gleb Mazovetskiy

Rails default Dockerfile build failed after added bootstrap gem

I'm not sure what importmaps have to do with any of this

Rails default Dockerfile build failed after added bootstrap gem

I'm considering making the `autoprefixer-rails` dependency optional in the next release. Please test #283.

isolating router: only match files with configured locales

> It requires the user to set the available locales in the i18n-tasks.yml configuration file, at least for the isolating router. That seems like a very significant requirement change. Can...

isolating router: only match files with configured locales

How about we simply fall back to the old behaviour if the locales aren't specified?

movie_lib.cc: Fix incorrect return type of `getOffset`

@alexbatalov Can you please merge this? The bug was introduced in your changes to my PR #117 when you were merging it.

movie_lib.cc: Fix incorrect return type of `getOffset`

@alexbatalov I see you're committing stuff again, can you please merge this?

Adds failing spec

This may be tricky to fix with a regex. Currently it is defined here: https://github.com/glebm/i18n-tasks/blob/d0453929603379bea15577065fecfc79a045290e/lib/i18n/tasks/scanners/ruby_key_literals.rb#L5 A possible workaround is to dissallow letters and `]` immediately after the `"`. This can...

Initial Integration of DAPI

clang-format does support `.proto` files natively but we should use the default Google configuration for those as that's what everybody else uses The easiest way to do this is to...

[Issue Report]: SDL_RenderSetIntegerScale() is required but not avalible in SDL 2.0.3

Ah, that function is only available since SDL 2.0.5, so we should guard against that Or perhaps just say that we require 2.0.5+

[Issue Report]: SDL_RenderSetIntegerScale() is required but not avalible in SDL 2.0.3

Let's see if the latest SDL2 works on 10.4 ppc mac with macports. If that works, we can simply bump the requirement. Might take a week to find out, things...