devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

[Issue Report]: SDL_RenderSetIntegerScale() is required but not avalible in SDL 2.0.3

Open AJenbo opened this issue 1 year ago • 5 comments

Operating System

Mac PPC

DevilutionX version

1.5.3

Describe

We support SDL 2.0.3 but when trying to build you get an error regarding SDL_RenderSetIntegerScale() not being found.

To Reproduce

Find an old version of SDL2, try to compile

Expected Behavior

No response

Additional context

No response

AJenbo avatar Nov 12 '24 11:11 AJenbo

Ah, that function is only available since SDL 2.0.5, so we should guard against that Or perhaps just say that we require 2.0.5+

glebm avatar Nov 13 '24 18:11 glebm

I'm ok with either. We could just hide the interger scale option on older SDL. PPC Mac has SDL 1.2.15 and 2.0.3. And so fare it feels like the SDL 1.2 port works better (but since I have only tested DevilutionX 1.0.3 not many features where available).

We already turn it off when SDL1.2 is in use.

AJenbo avatar Nov 15 '24 03:11 AJenbo

Looks like SDL_GetDisplayDPI and SDL_SetWindowResizable() are in a similar situation

AJenbo avatar Nov 15 '24 13:11 AJenbo

Let's see if the latest SDL2 works on 10.4 ppc mac with macports. If that works, we can simply bump the requirement.

Might take a week to find out, things are very slow to build

glebm avatar Nov 15 '24 18:11 glebm

The fact that if you click in the upper right corner you hit the OS search bar makes the SDL2 that is in tigerbrew really undesirable any way.

AJenbo avatar Nov 16 '24 01:11 AJenbo

Since the Tiger port is now using SDL1, nothing needs SDL 2.0.3 anymore, so I guess we can close this

glebm avatar Sep 01 '25 18:09 glebm