Gleb Mazovetskiy
Gleb Mazovetskiy
There isn't one but it'd be good to add it to the existing SDL1 Linux workflow
Looks good to me, just waiting for another maintainer to also have a look and merge! /cc @StephenCWills @AJenbo
Is the options toggle the only thing that's missing here?
@azihassan You may get better results with unpacked MPQs (reverting https://github.com/azihassan/devilutionX/commit/d6eb734ba7374017239e6c9a604fcb6016df653b), it saves a few hundred KiB of RAM. Are you on our Discord? https://discord.gg/devilutionx
> Packed MPQs are easier to deal with for people who want to use their own diabdat.mpq, but I've been meaning to switch back to unpacked to see if it...
> Monsters stopping in trigger tiles blocks access to that trigger for the player Perhaps trigger tiles should be allowed if they're next to the player?
The code looks good to me now. This will make the game more difficult but I think this is clearly a bugfix, so I'm in favour of it.
That makes sense.
> But as I'm writing it, I'm not sure that it's something that we should handle in LVGL but it can be user's responsibility to link the required libs as...
Note that one of my earlier attempts was a hack to allow the user to specify the list of extra libraries to link (https://github.com/lvgl/lvgl/pull/6958) but I later realized that it...