Gleb Mazovetskiy

Results 440 comments of Gleb Mazovetskiy

Thank you for the review, I'll get back to it next weekend. In the meantime, I figured out how to get some of the info on Tiger (though it requires...

This is neat to have in debug builds and is easy to get rid of if we want to in the future, so I'm marking this a ready for review.

The floor is drawn before everything else and I think floor tiles never overlap with each other That said, so far I haven't been able to get any performance improvement...

`foliage` is only checked in `DrawCell`, which is not used for drawing floor tiles: https://github.com/diasurgical/devilutionX/blob/7d5bef724dbfadb16cb1e36fb18f136a39929350/Source/engine/render/scrollrt.cpp#L475 Floor tiles are always drawn without mask (`MaskType::Solid`), doesn't look like our code supports foliage...

I think what happens is that foliage is drawn again in `DrawCell`, after the floor. The condition for whether something is a floor tile is exactly the same as `foliage`:...

I'm using the latest bundler release (1.13.6), RVM and ruby 2.3.1. I hesitate to provide a script because there is a non-trivial chance of this being closed as works-as-intended. Perhaps...

@segiddins Perhaps it can build the gem and use that instead? That's kind of what I was expecting. Perhaps as an option (`build: true`), preserving backwards compatibility. When loading from...

I was thinking more along the lines of allowing to override font lines with locale-specific ones (e.g. `fonts/{locale}/ab-cd.pcx` first, then `fonts/ab-cd.pcx`). I'm not sure what font we're using currently but...

@NikoVP The [Ideographic Variation Database](https://www.unicode.org/reports/tr37/) contains the list of characters with locale-specific variants but it's not guaranteed that the font actually has all of those variants. So I think a...