Gleb Mazovetskiy

@bebbo We do not do anything custom with the includes, we simply use the Amiga GCC container as-is. Sounds like the issue is with the container.

I've sent https://github.com/diasurgical/devilutionX/pull/6095 adding the missing `` includes to our own code (don't know if all of our dependencies do it correctly though). However, it seems to me like there...

Yeah that's what I thought would happen. We're not in control of libfmt code. The root cause of this should be fixed in the container.

We're down to the following errors on CI: ``` _deps/libfmt-build/libfmt.a(format.cc.obj): duplicate section `.text._ZN3fmt2v96detail15write_codepointILm2EcNS0_8appenderEEET1_S4_cm' has different contents _deps/libfmt-build/libfmt.a(format.cc.obj): duplicate section `.text._ZN3fmt2v96detail15write_codepointILm2EcNS0_8appenderEEET1_S4_cm' has different contents /opt/m68k-amigaos-gcc10/lib/gcc/m68k-amigaos/13.1.1/../../../../m68k-amigaos/bin/ld: Source/CMakeFiles/libdevilutionx.dir/missiles.cpp.obj:(.text._ZN10devilution12_GLOBAL__N_121UpdateMissileVelocityERNS_7MissileENS_7PointOfIiEEi+0x4e): undefined reference to `hypot' /opt/m68k-amigaos-gcc10/lib/gcc/m68k-amigaos/13.1.1/../../../../m68k-amigaos/bin/ld:...

Yep, that was it! Now green on CI 🎉 https://app.circleci.com/pipelines/github/diasurgical/devilutionX/17638/workflows/c243890a-ec5d-48d8-9eb2-c7ec45758d6f/jobs/111614/artifacts Thanks for debugging this with us!

Do you need to watch the array of markers for changes for this? If so, there is code in ui-calendar that watches arrays and calls onAdded/onChanged/onRemoved

Right. So you watch the array of user-supplied marker, and: onAdded(marker): new google.maps.marker onRemoved(marker): delete marker onChanged(marker): update marker position and other attributes The code that can efficiently watch for...

This doesn't take away the ability use native marker api if you want to. Why not offer both options? Simple common use case, and advanced use still possible.

By the way, looks like this implementation does automatic marker binding https://github.com/dylanfprice/angular-gm/blob/master/src/directives/gmMarkers.js

I use original DOM events, because I need to to do a hack outside of $apply. Will this change break them?