David Glasser
David Glasser
This looks good. But I made things harder for us by touching relevant parts in #6801 and #6808 too. I could resolve the conflicts myself but it might make more...
Also rename to `@apollo/`
As suggested in https://github.com/apollographql/apollo-server/issues/6048 we should make sure the documentation for the class is complete. We should decide if we want to canonical docs to be the README or the...
Note that some of its tests lived in ``` packages/apollo-server-core/src/__tests__/dataSources.test.ts packages/apollo-server-express/src/__tests__/datasource.test.ts ``` etc so recreate the integration tests from these files in the new repo!
As part of moving it, we should update it to be compatible with AS4 instead of AS3. Ideally this will involve having zero dependencies on Apollo Server (existing dependencies can...
When we do that, update the docs to note that it works with Gateway, including with what version.
Well, the important part here is that this allows you to configure just one cache that is used for multiple features such as the response cache, REST DataSources, APQs, etc....
Sure, I'm not saying it's the greatest idea, but you could make yourself an "UnprefixingCache" that's similar to https://github.com/apollographql/apollo-utils/blob/main/packages/keyValueCache/src/PrefixingKeyValueCache.ts but *removes* a prefix from keys instead of adding it. Then...
Another approach that makes it harder to accidentally share a cache's namespace across multiple features (which could lead to serious security vulnerabilities if you're able to poison one feature's cache...