apollo-server
apollo-server copied to clipboard
Review Suggestions for 6771
Feedback for https://github.com/apollographql/apollo-server/pull/6771
⚠️ No Changeset found
Latest commit: 10a35d10847ed8b409a2f0a987237a84c7770878
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Deploy Preview for apollo-server-docs ready!
| Name | Link |
|---|---|
| Latest commit | 10a35d10847ed8b409a2f0a987237a84c7770878 |
| Latest deploy log | https://app.netlify.com/sites/apollo-server-docs/deploys/62f299b07968b8000836e45a |
| Deploy Preview | https://deploy-preview-6780--apollo-server-docs.netlify.app/migration |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 10a35d10847ed8b409a2f0a987237a84c7770878:
| Sandbox | Source |
|---|---|
| Apollo Server Typescript | Configuration |
| Apollo Server | Configuration |
This looks good. But I made things harder for us by touching relevant parts in #6801 and #6808 too. I could resolve the conflicts myself but it might make more sense for you to do it, since "resolving the conflicts" includes more copyediting too?
I'm going to close this for now, and do a big migration article pass later to avoid conflicts!