David Glasser
David Glasser
That does seem useful. How confident are you that this will be fully backwards-compatible? Your sample code doesn't look great: it starts a new ApolloServer from scratch on every request....
Also one weird request — sometimes our CI does not run on contributor pull requests. I am told by CircleCI support that this is because you have logged in to...
Well, you do need the call the function. The most appropriate way to call an async function from the top level in Node kind of depends on your Node version...
Consider changing the TS defaults to newer: eg we can ask for es2020 rather than es2019. Or we can use `@tsconfig/node14` (https://www.npmjs.com/package/@tsconfig/node14) instead of declaring it ourselves.
This is a stretch goal for 4.0.0; I'm breaking out #6168 which is a must.
There is a lot about Apollo Server error handling that is counterintuitive. Cleaning this up is on the roadmap for Apollo Server 4. cc @IvanGoncharov
This looks like the same issue I closed at #6007. It seems like perhaps the way we publish this particular package doesn't work well with some particular JS build system....
Huh, that's news to me. Kinda surprised that the HTTP wg folks didn't reach out to server implementers when making that proposal, though maybe they did and we missed it....
I also note that it's not [registered with IANA](https://www.iana.org/assignments/media-types/media-types.xhtml#application).
The fix is probably just to call newNode (converting the array to the ResponsePath linked list) from addProtobufError instead of redirecting to the root.