David Glasser

Results 428 comments of David Glasser

For what it's worth: SchemaDirectiveVisitor is actually part of the separate [`graphql-tools`](https://www.graphql-tools.com/) project. While Apollo Server 2 lets you pass `schemaDirectives` to its constructor, it's just passed on to a...

https://github.com/apollographql/apollo-server/pull/3460 is related.

In AS3 we are making the CORS default behavior more *consistent* (always serving `acao: *` in all integrations). This is a great default for getting started with development, but not...

@yanickrochon This is documented in the migration guide: https://www.apollographql.com/docs/apollo-server/migration/#cors--is-now-the-default In AS2, apollo-server-koa had a different default from the other web framework integrations (and this wasn't even documented); we've aligned them...

Good to hear! I recommend using TypeScript so it's easier to put parameters in the right place.

While I know this isn't the most exciting thing to hear, I think this will get naturally fixed as part of [Apollo Server 4](https://github.com/apollographql/apollo-server/blob/main/ROADMAP.md) which we expect to ship in...

I think the simplest thing to do here would be to change the docs to compare codes rather than use `instanceof`, since that seems less brittle. Happy to take a...

I don't think I'll be able to help you debug this without a complete reproduction (eg something I can git clone or look at in codesandbox.io).

This should go into a minor release and have a changelog entry that makes it clear that the upgrade will have a minor one-time impact on your usage of Studio....