David Glasser
David Glasser
@brycefranzen It's basically impossible to review this PR since GitHub isn't recognizing the file rename. Is it possible to split into multiple commits, some of which do the rename and...
Thanks, this is now reviewable! @IvanGoncharov what do you think of this change?
I wonder if a better model would be for each error type to have a static `code` property so that it's `UserInputError.code` rather than `ErrorCode.USER_INPUT_ERROR`. Is it important to be...
Well the main reason is that we've completely rewritten error handling to simplify it a lot on the `version-4` branch, so I'd like to get input from @IvanGoncharov who did...
@brycefranzen It looks like #6705 ends up resolving this problem by adding ``` export enum ApolloServerErrorCode { GRAPHQL_PARSE_FAILED = 'GRAPHQL_PARSE_FAILED', GRAPHQL_VALIDATION_FAILED = 'GRAPHQL_VALIDATION_FAILED', PERSISTED_QUERY_NOT_FOUND = 'PERSISTED_QUERY_NOT_FOUND', PERSISTED_QUERY_NOT_SUPPORTED = 'PERSISTED_QUERY_NOT_SUPPORTED', BAD_USER_INPUT...
(Note that this doesn't include ErrorName, just error code, but I think the whole point of error code is it's the thing you should be matching against, so that seems...
We are removing FORBIDDEN and UNAUTHENTICATED since they have never been produced or treated specially by Apollo Server itself. (They are used by `apollo-datasource-rest`, but that's not really part of...
Note that this isn't a regression from AS3, but still would be nice to improve.
@stuartmclean Really? It's a completely unrelated cache.
Interesting! Note that using these new http.Server methods requires using Node v18.2, which is higher than the minimum requirement for Apollo Server (and even the currently planned minimum requirement for...