Garrett Johnson

icon indicating a website link https://gkjohnson.github.io/ icon indicating an email [email protected]

icon location Tokyo, Japan icon location Working on graphics, space robots, path tracing, and learning some new stuff. Get in touch if you want to work together.

Results 1078 comments of Garrett Johnson

TS type augmentations don't work w/ "moduleResolution": "node16"

Is it possible to use `declare module 'three'`, instead, and put both class modifications in the same block? That would be nicer, I think. If you could test and make...

Fix `InstancedMesh` raycast

> Shall I add tests on BatchedMesh too? (after https://github.com/mrdoob/three.js/pull/28462) If you don't mind I think this would be good to have

Fix `InstancedMesh` raycast

> Accelerated raycasting does not seem to work on BatchedMesh. > It is currently ignored because the temporary mesh geometry used for raycasting does not have the boundsTree property (unlike...

InstancedMesh regression in 0.7.5

Can you provide a live example using jsfiddle or something that shows the issue?

InstancedMesh regression in 0.7.5

Thanks - is it possible to make something that's immediately reproduce-able without having to manually move the camera or ray? Eg a static scene with a ray positioned such that...

When the shape key changes, the canvas does not respond to the change.

If you change anything that will modify geometry in the scene you need to call `setScene`, again. If it's still not working then it's possible that the caching mechanism isn't...

TilesRendererBase: Add more "structure" for cached, per-engine fields

This change will also allow more events to be moved to the TilesRendererBase since the event content passes the "scene" to the event body.

Add overload from the docs to MeshBVHHelper type

Hey! Thanks for the catch - this looks like bug introduced in #703 since [this line](https://github.com/gkjohnson/three-mesh-bvh/blob/master/src/objects/MeshBVHHelper.js#L289) is not checking whether or not `mesh` is defined. The constructor signatures in the...

Add overload from the docs to MeshBVHHelper type

Fixed in d437524

BatchedMesh: `bufferSubData` causes lag

> I'm a little off topic perhaps, but note that you could switch between LODs generated by meshoptimizer without changing the vertex buffer at all. Update the index, set draw...