Garrett Johnson
Garrett Johnson
> 🎖 for picking up and refining my idea and going ahead with making a PR. Ha hopefully it doesn't feel like I stole your thunder! I just felt like...
> Have you run any tests with normal and more exotic cases? Only the one I mentioned above. Here are the cyclic cases the @donmccurdy mentioned in https://github.com/mrdoob/three.js/issues/17299#issuecomment-525539687, which might...
> One target attached to an object, and many lights with different relation to it pointing at it. Yeah that will work, too: ```js const scene = new THREE.Scene(); const...
Can you sketch out a hierarchy that you expect to be a problem along with which node should be cloned to illustrate the issue? I'm not sure if I'm following...
With the PR as it is now cloning `obj` will result in a clone of the complete tree as you've sketched it including the scene which will be the clone...
It turns out this is causing issues with GLTF files when you clone them, as well, since the target object is no longer added as a child of the directional...
This looks like it's related to, if not a duplicate of, #25353 which shows that rendering to 3d render targets fails in D3D backends (which is used in both reported...
This is the reality of raycasting exactly on a shared edge of two triangles, I think. You'll see that three.js' `raycaster.interectObject` exhibits the same issue. A raycast here will either...
The fiddle isn't comparing the same calculations. Three.js' Mesh class transforms the ray by [the inverted world matrix](https://github.com/mrdoob/three.js/blob/dev/src/objects/Mesh.js#L180) (in this case an identity matrix) which will still have a small...
Should this line ```ts declare module 'three/src/core/BufferGeometry' ``` be changed to this? ```ts declare module 'three' ``` Unfortunately I'm not a typescript expert so please feel free to make a...