Garrett Johnson

Results 1078 comments of Garrett Johnson

Awesome change! Are there any plans to allow for passing in a DataView or Uint8Array with a byte offset into `parse`? Some formats like B3DM are wrapping GLTF so you...

@mrdoob I've updated this PR to use the tests and have implemented the aforementioned steps 2 and 3 in other branches to verify the behavior. I can make PRs for...

@mrdoob just wanted to ping about this again now that r119 is out. This PR only adds functions to `WebGLRenderLists` but does not use them yet so there shouldn't be...

@mrdoob Just wanted to ping about this again -- render order is really a pain to manage once an application gets large and it's really difficult to explain to new...

ping @mrdoob -- just got all the conflicts resolved, updated the other two PRs, and tested it again. At the moment transmissive materials do not respect the group render order...

@Mugen87 > As outlined earlier (see #18937 (comment)), I do not vote to make this change and leave the code as it is for greater flexibility. I saw and I...

@mrdoob > I think we could add `layers.recursive = true; // false by default` Thanks that works for me! I am curious as to the reasoning behind wanting to keep...

@mrdoob I just made the changes! If `object.layers.recursive` is true then that parents layers will affect rendering and raycasting of children. I've added a unit test for raycasting and tested...

@mrdoob any further thoughts on this PR? If needed I can try to explain the logic more clearly. Would it help if I separated the separated the conditions instead of...

> Classes like InstancedMesh or SkinnedMesh needs to be considered in order to compute proper AABBs and bounding spheres. I agree -- there are cases even with just a mesh...