Garrett Johnson

Results 1078 comments of Garrett Johnson

> I think what was meant by @bhouston is rather loading IES profiles by parsing them and then creating lights using three.js' lights' own constructor parameters (i.e. intensity/distance/so on). IES...

> And I think IESLight and IESLoader would better go in examples rather than core... If you look at the code it requires core shader changes...

> Would it make sense to do always do this when material.transparent === true and avoid introducing material.depthPrepass? I think my answer when asking if we should remove options or...

My feeling is that the behavior of scene.background when set to a solid color should be consistent when scene.background is set to a texture. Looking at the code when using...

I'll just not here as I have in other issues that naming this field something like `canvasColorSpace` could be more clear.

> I'm not sure I understand this fix - the resolution is set on the frame rate The render resolution on the material is set twice -- once for the...

I don't have strong opinions about whether or not it should be in the example. I can remove it if you want.

@mrdoob aside from whether the subframe should be in the example I think this should be merged. Right now the example looks broken. If we'd like to update it to...

Something isn't lining up, then. The Collada "Elf" model doesn't specify a `` tag for any of its textures meaning if that's true then we're displaying our Collada models in...

> If you just set outputEncoding to sRGBEncoding, the sRGB workflow is incomplete. Can you explain this? It should _never_ be correct to display the canvas as Linear on the...