Garrett Johnson

Results 1078 comments of Garrett Johnson

Hey @marcofugaro! I've toyed with the idea of maintaining a package of some of the effects in my sandbox repo but I'm finding I don't have the time with everything...

@marcofugaro > By all means, you can make the PR as well if you want, I just want to be able to use the MotionBlur pass with this easy-to-use library....

Just want to chime in that this would be a great addition though it would be nice to be able to retain both a synchronous and asynchronous code paths -...

I'm not sure what's up the "webgl_shadowmap_pointlight" screenshot here - can someone else give regenerating it a try?

@Mugen87 @mrdoob is there any way to see the output screenshot from CI to compare with the uploaded screenshots to see what the differences might be?

> It is an essential part of the E2E test -- the difference screenshots are autogenerated, so you can just download the artefact from the run and see them there....

@sunag thank you! Well this is ready to merge, again, if we could.

> it's best to reimplement this feature with the nodes system for WebGPURenderer and with a fresh PR I believe it's already been addd in #25238. @Wagyx it would be...

cc @ariel-resonai @bergden-resonai I think this change looks right but I'd appreciate if you guys can confirm.

Hey @elalish! I've made quite a few fixes and releases over the last several months that have made significant improvements to the fidelity of the examples. You can see the...