Garrett Johnson
Garrett Johnson
Excellent! Nice work! And thanks again
Amazing! I'll take a deeper look in a bit - but the first thing that sticks out is lint issues. If you run `npx eslint "./example/*.js" --fix` that should fix...
Oh can we update the README to include a new link to the diamond demo in the "Path Tracing" section, as well?
How do you feel about using one of these existing equirect maps for the environment that are already uploaded to my '3d-demo-data' repo? `https://raw.githubusercontent.com/mrdoob/three.js/dev/examples/textures/equirectangular/royal_esplanade_1k.hdr`  `https://raw.githubusercontent.com/mrdoob/three.js/dev/examples/textures/equirectangular/venice_sunset_1k.hdr`  `https://raw.githubusercontent.com/gkjohnson/3d-demo-data/master/hdri/leadenhall_market_1k.hdr`  `https://raw.githubusercontent.com/gkjohnson/3d-demo-data/master/hdri/circus_arena_1k.hdr`...
@N8python when you have a chance can you update this with some of the new diamond shader code including fresnel and dispersion - and then I can clean up the...
Whenever you have a moment! To me it's okay if it's not exactly up-to-date with the drei, version. Over time they will drift out of sync, anyway, but really I...
Awesome, thank you! > one concern is that there is a form of mipmap aliasing caused by the Equirect environment that I'm not sure how to fix - it doesn't...
> > Are these lines what you're referring to? I'll try to see what might be causing them when I get a chance. I see they get more noticeable as...
Perhaps the documentation could be updated but setting `raycaster.firstHitOnly` only affects the behavior at the individual Mesh level - ie when performing a raycast into a mesh it will early...
> raycaster.firstHitOnly can deliver more than two intersections for raycaster.intersectObjects([mesh1, mesh2]) as a result if the material.side is DoubleSide. Is this also as designed? This doesn't sound right. Can you...