Garrett Johnson

Results 1078 comments of Garrett Johnson

> As far as I can see, not special handling was done when three.js used XMLHttpRequest that can already be aborted. As far as I know there was no method...

> I used it in https://github.com/mistic100/Photo-Sphere-Viewer and it worked perfectly. I see. Thanks I didn't realize FileLoader returned the request. Either way it seems the the requests could not be...

> Okay I understand your point. But is it really useful though ? I think it is useful to be able to reuse an AbortController, yes. If a user is...

> Is there a way of implementing this without having to modify all the loaders? 🤔 I expect there'd have to be some kind of change to all loaders -...

I know nothing of the GCode format but from the [loader example](https://threejs.org/examples/?q=gcode#webgl_loader_gcode) it looks like it's just a series of nozzle movements for each 3d printed layer of the object....

> It sounds like we should be explicitly rounding to N digits, rather than truncating? This will have the same problem - both truncating and rounding bin the space and...

> That will still be a bug, but a little less severe one: the bin around 1.0 is now [1.0, 1.0001) and when rounding would be [0.9995, 1.0005) which is...

> I meant that it would cause the problem to appear less often, especially in parametric models. > I have no issue with rounding instead of truncating if it helps...

> They aren't CJS but are "UMD-like" enough that the usage can be: If we're going to consider supporting require/commonjs we should do it right. I was going to suggest...

> We already support the UMD-like path above It's not correct to call that a UMD-like path. UMD is module definition designed to support commonjs, amdjs, and global script definitions....