Garrett Johnson

Results 1078 comments of Garrett Johnson

> `sampler.getAttribute( face, weights, 'position', position );` It might be a harder change to convince the project of but I could see this being added to core BufferGeometry to make...

@mrdoob > I do not understand. This was not an issue before WeakMaps were introduced? It seems it's always been an issue but as @Mugen87 mentioned by using WeakMaps we...

Thanks for isolating the issue to a small file! I will not have the bandwidth to investigate this but if you'd like to take a deeper look you can check...

> I dived deeper in LDrawLoader, and found the issue occurs with the Triangles or Quadrilateral which need double sides. Gotcha - yes I don't believe there have been many...

@graywhale are you planning to make a PR to fix the issue and contribute it back to the project?

That is a git commit - if you would like to make a contribution to three.js you need to make a PR into the mrdoob/three.js repo. There is some documentation...

Are we against calling this something like "ProjectorLight", then, if a SpotLight modification isn't acceptable? I agree that "RectLight" is a bit confusing.

> As I said before, I'm not sure the additional code complexity warranted by a ProjectorLight would be worth it - given how simple the modifications to the SpotLight are....

I agree this would be a nice addition -- I don't think the LoadingManager is the right place to call cancel, though, because it would cancel all requests related to...

> Hmm, I wonder if there is a more elegant approach... I think there is -- and I don't think passing an abort signal into `Loader.load` is necessarily a complete...