Garrett Johnson

Results 1078 comments of Garrett Johnson

Looking at this again I'm wondering if there is some issue with the logic in comparing the compatibility of semver ranges when there is no concrete package version available. Looking...

> I expect that including a peer dependency semver range that supports react 19 will fix this conflict issue. I've just published and tested a new version of the 3d-tiles-renderer...

> all my tiles have tile.__distanceFromCamera: Infinity Do you have a repro of this? I'm seeing that tiles outside the frustum have a "distanceToCamera" of Infinity but are otherwise set...

Thanks - looks like this was a variable name that got changed in one place and not the other. Fixed in https://github.com/NASA-AMMOS/3DTilesRendererJS/commit/a0be772f1e526242b98b7267167b9a01819daf19.

Hello! One immediate issue to start is that the BVH builder is designed and optimized for triangles and triangles alone at the moment. It's on my list to experiment with...

> I'm referring to this demo: https://www.shadertoy.com/view/MfjGzD Yeah as you mention this seems very dependent on a consistent object size and doesn't seem like it would work well for gaussian...

Nice work! Looks great - you could probably squeeze out a bit more performance by sorting and accumulating the splat color inside the "bvhIntersectSplats" instead of exiting the function and...

It looks great! > I don't quite understand how this optimization would work. The BVH traversal returns splats in an unordered fashion, so if I stop when the splats buffer...

For async / generator approach: - Requires ensuring proper scoping of the functions and stacks to avoid async execution conflicts. - Provide a separate generator function called something like `shapecastIterator`,...

> But it does constrain users' choices, and can force an additional (expensive!) pass in a post-processing stack. Based on feedback, this is problematic for mobile applications. Do you have...