Gary Katsevman comments

Results 538 comments of


                                            Gary Katsevman

test case for issue #60

So, this PR _should_ create a failing testcase?

test case for issue #60

Yeah, totally, just wanted to make sure I'm understanding it correctly. :smile_cat:

Infinite recursion

@vkovalskiy unfortunately, both I and @afeld are pretty busy. I'll try to get to this in the following week or two.

Infinite recursion

That may very well be the best way to handle it :grin:

Does not work together with the new Backbone 1.1.1

Yeah, I wish that backbone didn't release it as 1.1.1. It should not be a patch version bump. Minor at least. We'll take a look.

Does not work together with the new Backbone 1.1.1

Unfortunately, that project is not interested in semver. Interestingly enough, the tests pass just fine. Though, that's probably because the tests don't use AMD.

Does not work together with the new Backbone 1.1.1

It seems to work for me. See https://gist.github.com/gkatsev/9096687

Does not work together with the new Backbone 1.1.1

I wonder if the AMD stuff get mangled and thus become useless. Could you post your minified versions to something like jsbin or jsfiddle?

changedAttributes return entire deep object instead of only the changed field

Backbone 1.x (and 0.9.9) support has landed in master. Can you retest and see whether this is still a problem?

change event options parameter not detailed enough

Can you please retest using the backbone 1.x supported backbone-nested that's currently in master? It's possible that with how things are working now, we're getting this now. Thanks.